Jump to content

Help Critique Me?


Nightmares
 Share

Recommended Posts

Kinopiron.com

 

I started this project in 2010. Once I reached my senior year in high school- The project was dropped and I have recently started back within the last 3 months and even managed to recover some of my old staff... 

I designed the layout and created it.

I coded it.

Before I teach myself back end development- please tell me honest opinions? I wanted something that kind of look like a classic VPS?

I also wouldn't turn down any help regarding this as well... programming and coding wise. I am skimming through everything but I really just would like to know outsiders opinions before moving forward?

  • Like 1
Link to comment
Share on other sites

There are a few "classic neopets" and other sites which have their owners really focused on the 'classic' elements.  I would say even if not a ton of people join if you have fun and learn from it, I would say go for it!

Link to comment
Share on other sites

18 hours ago, judda said:

There are a few "classic neopets" and other sites which have their owners really focused on the 'classic' elements.  I would say even if not a ton of people join if you have fun and learn from it, I would say go for it!

Thank bunches lovie! 

Misticpets actually is a heavy influencer for me. 

  • Like 1
Link to comment
Share on other sites

Its definitely got that old school vibe down well, you've done a really good job there!

In terms of your markup (the HTML you've written), a couple of points:

* Some of the elements you've used are in unusual places and are duplicated for some reason(??), not sure what's going on there, but provided a simple example below to show what I mean for how it should be laid out.

<html>
  <head>
    <title>title</title>
    <meta />
    <link />
  </head>
  <body>
    <div>content</div>
    <script src />
  </body>
</html>

* I would maybe suggest changing the header image so the whole thing isn't a fixed image, but just the center bit is, then do the side pieces as <div> so you can easily add content into them. Plus if you want to change up the navigation later, having to change some <div>s is a lot easier than image manipulation each time!

* Maybe make it so that when you click the banner you go back to the index page, cause right now there's no way back.

 

Hope these few things help, if you need some assistance with css for the layout feel free to ask and I'll see what I can do 🙂

  • Like 1
Link to comment
Share on other sites

On 10/31/2022 at 9:55 AM, crotanite said:

Its definitely got that old school vibe down well, you've done a really good job there!

In terms of your markup (the HTML you've written), a couple of points:

* Some of the elements you've used are in unusual places and are duplicated for some reason(??), not sure what's going on there, but provided a simple example below to show what I mean for how it should be laid out.

<html>
  <head>
    <title>title</title>
    <meta />
    <link />
  </head>
  <body>
    <div>content</div>
    <script src />
  </body>
</html>

* I would maybe suggest changing the header image so the whole thing isn't a fixed image, but just the center bit is, then do the side pieces as <div> so you can easily add content into them. Plus if you want to change up the navigation later, having to change some <div>s is a lot easier than image manipulation each time!

* Maybe make it so that when you click the banner you go back to the index page, cause right now there's no way back.

 

Hope these few things help, if you need some assistance with css for the layout feel free to ask and I'll see what I can do 🙂

So... "easy" I can't do.. I can't cook noodles or rice but give me a sushi recipe, fried rice, steaks, anything incredibly hard and I can accomplish- resin work? GOT YOU. I can paint all kinds of designs in it- right? Basically easy is something hard for me to wrap my head on... I completely forgot the home page button... anywhere.

 

so yea. I took  a few days break because of my daughter's birthday but I logged onto my desktop today with full intentions to fix some stuff- lol. So I will be makin the banner a click back for home page as well as adding "HOME" in the link side bar. 

Link to comment
Share on other sites

On 10/31/2022 at 9:55 AM, crotanite said:

Its definitely got that old school vibe down well, you've done a really good job there!

In terms of your markup (the HTML you've written), a couple of points:

* Some of the elements you've used are in unusual places and are duplicated for some reason(??), not sure what's going on there, but provided a simple example below to show what I mean for how it should be laid out.

<html>
  <head>
    <title>title</title>
    <meta />
    <link />
  </head>
  <body>
    <div>content</div>
    <script src />
  </body>
</html>

* I would maybe suggest changing the header image so the whole thing isn't a fixed image, but just the center bit is, then do the side pieces as <div> so you can easily add content into them. Plus if you want to change up the navigation later, having to change some <div>s is a lot easier than image manipulation each time!

* Maybe make it so that when you click the banner you go back to the index page, cause right now there's no way back.

 

Hope these few things help, if you need some assistance with css for the layout feel free to ask and I'll see what I can do 🙂

 

 

 

 

Also this is my code for index.php:

 

<?php

include 'header.php';
include 'leftside.php';

?>


<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Kinopiron | Home</title>
    <link rel="stylesheet" href="Kinopiron.css">
</head>

<body>
    <div class="Contentbox"><p class="Content"> 
    <img class="map" src="map2.jpg">
            <br>Testing Testing adding some words to test this out.
            <br> Testing and adding more words.
            <br>Kinopiron Kinopiron Kinopiron1<br> Whoop Whoop



    </p></div>
</body>

</html>

and I am using visual code studio and XAMPP for the server.

I type the exclamation point and it auto inserts everything and I have just gone in to put it needed to include the header and left side bar and type in my <div> and <p> class. 

Link to comment
Share on other sites

On 11/3/2022 at 8:53 AM, Nightmares said:

Also this is my code for index.php:

 

<?php

include 'header.php';
include 'leftside.php';

?>


<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Kinopiron | Home</title>
    <link rel="stylesheet" href="Kinopiron.css">
</head>

<body>
    <div class="Contentbox"><p class="Content"> 
    <img class="map" src="map2.jpg">
            <br>Testing Testing adding some words to test this out.
            <br> Testing and adding more words.
            <br>Kinopiron Kinopiron Kinopiron1<br> Whoop Whoop



    </p></div>
</body>

</html>

and I am using visual code studio and XAMPP for the server.

I type the exclamation point and it auto inserts everything and I have just gone in to put it needed to include the header and left side bar and type in my <div> and <p> class. 

So the good thing is you don't have a ton to change to make things valid, you would just need to move your include statements into the actual `body` section.  That being said, I would probably tweak it a little bit more so you aren't having to write the `<html>` every time.  Pop all of that stuff into the `header.php` and you are golden.

<?php
$pageTitle = 'News';

include 'header.php';
?>    
<img class="map" src="map2.jpg">
            <br>Testing Testing adding some words to test this out.
            <br> Testing and adding more words.
            <br>Kinopiron Kinopiron Kinopiron1<br> Whoop Whoop
<?
include 'footer.php';

Then your respective files would look something like this ...

`header.php`

<html>
<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Kinopiron | <?php echo $pageTitle ?? 'Home'; ?></title>
    <link rel="stylesheet" href="Kinopiron.css">
</head>
<body>
<?php
include 'leftside.php'; // Or this could just be included in here

Then your `leftside.php` would include the stuff for the container.

Link to comment
Share on other sites

On 11/8/2022 at 4:48 AM, judda said:

So the good thing is you don't have a ton to change to make things valid, you would just need to move your include statements into the actual `body` section.  That being said, I would probably tweak it a little bit more so you aren't having to write the `<html>` every time.  Pop all of that stuff into the `header.php` and you are golden.

<?php
$pageTitle = 'News';

include 'header.php';
?>    
<img class="map" src="map2.jpg">
            <br>Testing Testing adding some words to test this out.
            <br> Testing and adding more words.
            <br>Kinopiron Kinopiron Kinopiron1<br> Whoop Whoop
<?
include 'footer.php';

Then your respective files would look something like this ...

`header.php`

<html>
<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Kinopiron | <?php echo $pageTitle ?? 'Home'; ?></title>
    <link rel="stylesheet" href="Kinopiron.css">
</head>
<body>
<?php
include 'leftside.php'; // Or this could just be included in here

Then your `leftside.php` would include the stuff for the container.

Well... don't hate me but I completely changed everything up and once I can get everything situated and done with the main coding (still have a few more pages to add dummy text to and the layout and such and then I am starting other confusing things that I still don't quite understand but getting the hang of it) - I will show everyone. I dug through my old development forums from 2010 and saw where we wanted it to be like a social media network kind of thing. I am trying to figure out how to include a social media look to it while still having the functions and activity of a pet site. This is going to be interesting and I honestly can not wait to share with you..

  • Like 2
Link to comment
Share on other sites

Super cool! Making a pet game is fun ♥ I think that if you're going with classic, you'll want to make sure it's still modern enough to work well on mobile devices.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...